Skip to content

Remove unimplemented CSS line-height-step property #26761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

Remove unimplemented CSS line-height-step property #26761

merged 2 commits into from
May 9, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 9, 2025

Summary

Removes the Chrome statement for line-height-step, because it was only behind a flag, and the feature got removed.

Test results and supporting details

See:

Related issues

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed labels May 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@caugner caugner requested a review from Elchi3 May 9, 2025 13:11
Elchi3
Elchi3 reviewed May 9, 2025
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this data? Seems irrelevant to me per our data guidelines.

I was hoping to enable the linter for CSS at some point soon (just 21 data points left to remove).

See

browser-compat-data/lint/linter/test-obsolete.ts

Line 16 in 4f70626

const ignoredCategories = ['css'];

@caugner
Copy link
Contributor Author

caugner commented May 9, 2025

Ah, and I was wondering why the linter doesn't warn.

@caugner caugner changed the title Chrome 110 removed CSS line-height-step Remove unimplemented CSS line-height-step property May 9, 2025
@github-actions github-actions bot added size:m [PR only] 25-100 LoC changed and removed size:s [PR only] 7-24 LoC changed labels May 9, 2025
@caugner caugner requested a review from Elchi3 May 9, 2025 13:43
@Elchi3 Elchi3 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label May 9, 2025
@Elchi3 Elchi3 merged commit d1b3a1c into main May 9, 2025
11 checks passed
@Elchi3 Elchi3 deleted the line-height-step-in-chrome branch May 9, 2025 13:46
@mdn-bot mdn-bot mentioned this pull request May 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS needs content update This PR needs a corresponding update to mdn/content to update the documentation size:m [PR only] 25-100 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @Elchi3